1. 15 May, 2018 2 commits
  2. 19 Jan, 2018 3 commits
  3. 04 Nov, 2017 1 commit
    • Mark Hills's avatar
      Dither is local to this file · 33bffba2
      Mark Hills authored
      Useful to know this as there's implications with threads and the static
      state variable used for random numbrs.
      33bffba2
  4. 24 Jun, 2017 2 commits
    • Mark Hills's avatar
      Honour the search locale · 6d7c0bf2
      Mark Hills authored
      Keep a cache of any records which needed converting to the ASCII
      locale used for searching.
      
      These changes would have to be broadened if somebody wanted to
      search in a more complex locale; currently the only characters
      allowable are [a-z0-9]. It would need a greater understanding of
      how SDL handles the user input.
      6d7c0bf2
    • Mark Hills's avatar
      Simplify · de009a79
      Mark Hills authored
      It's valid to call free() on a NULL pointer, so use this.
      de009a79
  5. 14 Jun, 2017 1 commit
    • Mark Hills's avatar
      Honour the system locale · f39de371
      Mark Hills authored
      We have limited options for text rendering, so must do a conversion
      from the system locale to UTF-8 where necessary.
      
      Deliberately not using TTF_RenderUNICODE and wchar_t conversion,
      despite it being simpler;  because the system wchar_t is 32-bit,
      but SDL's idea of unicode is 16 bit.
      
      Leave iconv out of the path of the rendering that happens every
      frame as these are known non-unicode strings.
      f39de371
  6. 04 Mar, 2017 2 commits
    • Mark Hills's avatar
      A better random number generation for dither · 0a7585cc
      Mark Hills authored
      Increase the LFSR sequence for a longer cycle time, and reduce the number
      of bits driving the randomness so that it takes even longer to cycle.
      0a7585cc
    • Mark Hills's avatar
      Use of the wrong type causes the dither to converge · 108d9f79
      Mark Hills authored
      Thanks to Stefan Berg-Johansen for a high quality bug report.
      
      > The type declaration on line 79 in`player.c` should read `static
      > unsigned short x = 0xbabe;`. In the current master branch, `x` is a
      > static _signed_ short, which results in it taking on negative values
      > outside of the intended range. Another side effect is that the
      > returned sequence happens to converge after about 15 calls to a
      > small negative number, so effectively the current dither function
      > only imposes a small constant offset and nothing else.
      108d9f79
  7. 14 Aug, 2016 2 commits
    • Mark Hills's avatar
      Summarise changes · de5e2106
      Mark Hills authored
      de5e2106
    • Mark Hills's avatar
      Yearly update · b9688da9
      Mark Hills authored
      This is the first time we've done this twice on one release; shows
      how long some of these patches have been waiting for.
      b9688da9
  8. 11 Aug, 2016 2 commits
  9. 31 Oct, 2015 1 commit
    • Mark Hills's avatar
      Prevent an empty match being seen as an error condition · 802fc32c
      Mark Hills authored
      Because grep returns non-zero error code if no matches were found,
      the script considers this an error condition.
      
      Switch to using "find -regex". I chose the posix-egrep syntax as this
      seems to be one of the standard formats which gives the most concise
      syntax for the regex itself.
      
      When this code was originally put in place there was some debate, and
      I wrote on the mailing list (29 Jan 2012):
      
      > I merged the changes just now, but I did it using grep instead of
      > iregex. And found that grep does not do a full-string match by default.
      >
      > I chose grep -E for a couple of minor reasons:
      >
      > * more widely available
      >
      > * matching in a separate thread to the 'find' could give marginally
      >   better performance
      >
      > Nothing seriously wrong with the other method though :-) Anyway, it's in
      > the beta now, so everyone can give it a test.
      
      In light of the information on error conditions, switch to the regex
      case. This breaks compatibility with non-GNU find implementations.
      802fc32c
  10. 13 Sep, 2015 1 commit
  11. 22 May, 2015 2 commits
    • Mark Hills's avatar
      Use DEFAULT_SOURCE · 3926905a
      Mark Hills authored
      We get the following warning on build:
      
      In file included from /usr/include/assert.h:35:
      /usr/include/features.h:148:3: warning: "_BSD_SOURCE and _SVID_SOURCE are
            deprecated, use _DEFAULT_SOURCE" [-W#warnings]
      
      This is a FAQ in the linux-man project [*]
      
        You are compiling the code on a system that has glibc 2.20 or later
        installed. In glibc 2.20, the _BSD_SOURCE and _SVID_SOURCE feature
        test macros were deprecated
      
      [*] http://man7.org/tlpi/code/faq.html
      3926905a
    • Mark Hills's avatar
      Yearly update · 49ceb191
      Mark Hills authored
      49ceb191
  12. 10 Nov, 2014 1 commit
  13. 02 Nov, 2014 4 commits
  14. 22 May, 2014 1 commit
  15. 18 May, 2014 7 commits
  16. 09 Apr, 2014 6 commits
  17. 22 Mar, 2014 2 commits
    • Mark Hills's avatar
      Grammar correction · cf01f0ef
      Mark Hills authored
      cf01f0ef
    • Mark Hills's avatar
      Prefer largest buffer size up to the user's limit · 2284ba64
      Mark Hills authored
      Previously we were setting the maximum buffer size. For some soundcards
      this could allow the device to selecta much smaller buffer, leading to
      overruns.
      
      Be more specific by using _near, which should match the user's expectations
      and perhaps will fix problems with some soundcards.
      2284ba64