1. 04 Mar, 2017 1 commit
    • Mark Hills's avatar
      Use of the wrong type causes the dither to converge · 108d9f79
      Mark Hills authored
      Thanks to Stefan Berg-Johansen for a high quality bug report.
      
      > The type declaration on line 79 in`player.c` should read `static
      > unsigned short x = 0xbabe;`. In the current master branch, `x` is a
      > static _signed_ short, which results in it taking on negative values
      > outside of the intended range. Another side effect is that the
      > returned sequence happens to converge after about 15 calls to a
      > small negative number, so effectively the current dither function
      > only imposes a small constant offset and nothing else.
      108d9f79
  2. 14 Aug, 2016 2 commits
    • Mark Hills's avatar
      Summarise changes · de5e2106
      Mark Hills authored
      de5e2106
    • Mark Hills's avatar
      Yearly update · b9688da9
      Mark Hills authored
      This is the first time we've done this twice on one release; shows
      how long some of these patches have been waiting for.
      b9688da9
  3. 11 Aug, 2016 2 commits
  4. 31 Oct, 2015 1 commit
    • Mark Hills's avatar
      Prevent an empty match being seen as an error condition · 802fc32c
      Mark Hills authored
      Because grep returns non-zero error code if no matches were found,
      the script considers this an error condition.
      
      Switch to using "find -regex". I chose the posix-egrep syntax as this
      seems to be one of the standard formats which gives the most concise
      syntax for the regex itself.
      
      When this code was originally put in place there was some debate, and
      I wrote on the mailing list (29 Jan 2012):
      
      > I merged the changes just now, but I did it using grep instead of
      > iregex. And found that grep does not do a full-string match by default.
      >
      > I chose grep -E for a couple of minor reasons:
      >
      > * more widely available
      >
      > * matching in a separate thread to the 'find' could give marginally
      >   better performance
      >
      > Nothing seriously wrong with the other method though :-) Anyway, it's in
      > the beta now, so everyone can give it a test.
      
      In light of the information on error conditions, switch to the regex
      case. This breaks compatibility with non-GNU find implementations.
      802fc32c
  5. 13 Sep, 2015 1 commit
  6. 22 May, 2015 2 commits
    • Mark Hills's avatar
      Use DEFAULT_SOURCE · 3926905a
      Mark Hills authored
      We get the following warning on build:
      
      In file included from /usr/include/assert.h:35:
      /usr/include/features.h:148:3: warning: "_BSD_SOURCE and _SVID_SOURCE are
            deprecated, use _DEFAULT_SOURCE" [-W#warnings]
      
      This is a FAQ in the linux-man project [*]
      
        You are compiling the code on a system that has glibc 2.20 or later
        installed. In glibc 2.20, the _BSD_SOURCE and _SVID_SOURCE feature
        test macros were deprecated
      
      [*] http://man7.org/tlpi/code/faq.html
      3926905a
    • Mark Hills's avatar
      Yearly update · 49ceb191
      Mark Hills authored
      49ceb191
  7. 10 Nov, 2014 1 commit
  8. 02 Nov, 2014 4 commits
  9. 22 May, 2014 1 commit
  10. 18 May, 2014 7 commits
  11. 09 Apr, 2014 6 commits
  12. 22 Mar, 2014 2 commits
    • Mark Hills's avatar
      Grammar correction · cf01f0ef
      Mark Hills authored
      cf01f0ef
    • Mark Hills's avatar
      Prefer largest buffer size up to the user's limit · 2284ba64
      Mark Hills authored
      Previously we were setting the maximum buffer size. For some soundcards
      this could allow the device to selecta much smaller buffer, leading to
      overruns.
      
      Be more specific by using _near, which should match the user's expectations
      and perhaps will fix problems with some soundcards.
      2284ba64
  13. 12 Feb, 2014 2 commits
  14. 09 Feb, 2014 2 commits
  15. 31 Jan, 2014 1 commit
  16. 30 Jan, 2014 5 commits
    • Mark Hills's avatar
      Document the re-scan feature · 5eae4172
      Mark Hills authored
      5eae4172
    • Mark Hills's avatar
      Summary of changes · ebbedf0c
      Mark Hills authored
      ebbedf0c
    • Mark Hills's avatar
      Do not ever reduce the selector to zero lines · db25000b
      Mark Hills authored
      In some edge cases of the layout the caller has decided there is enough
      room to draw the library, but then there isn't an zero rows can be
      fitted.
      
      This is an indication that the whole layout functionality needs a re-think
      in the way it deals with making areas invisible as they become too small.
      
      A possible solution for later is separation into a layout and then a redraw
      step, whereas at the moment the two are tightly coupled.
      
      I tested with
      
        xwax -g /2.4
      
      which prior to this patch crashes instantly.
      db25000b
    • Mark Hills's avatar
      Separate index memory allocation · e43976e6
      Mark Hills authored
      Do memory allocatin within the index as a separate step.
      It means that calling code can reserve memory up front and then
      the insert/add functions cannot fail (and therefore no tricky
      recovery code needs to be written.)
      
      It also provides a simple optimistion in the index_copy() case.
      e43976e6
    • Mark Hills's avatar
      Move the responsibility for adding controller to realtime · 41c32d0c
      Mark Hills authored
      Fixes the FIXME.
      41c32d0c